lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5215) Add support for FieldInfos generation
Date Mon, 16 Sep 2013 03:49:51 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768041#comment-13768041
] 

Shai Erera commented on LUCENE-5215:
------------------------------------

It's ok that SWS contains fieldInfos - FieldsWriter needs to write them. And I don't think
it's bad SRS contains fieldInfos, we can just assert in FieldsReader that they are null?
                
> Add support for FieldInfos generation
> -------------------------------------
>
>                 Key: LUCENE-5215
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5215
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: core/index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>
> In LUCENE-5189 we've identified few reasons to do that:
> # If you want to update docs' values of field 'foo', where 'foo' exists in the index,
but not in a specific segment (sparse DV), we cannot allow that and have to throw a late UOE.
If we could rewrite FieldInfos (with generation), this would be possible since we'd also write
a new generation of FIS.
> # When we apply NDV updates, we call DVF.fieldsConsumer. Currently the consumer isn't
allowed to change FI.attributes because we cannot modify the existing FIS. This is implicit
however, and we silently ignore any modified attributes. FieldInfos.gen will allow that too.
> The idea is to add to SIPC fieldInfosGen, add to each FieldInfo a dvGen and add support
for FIS generation in FieldInfosFormat, SegReader etc., like we now do for DocValues. I'll
work on a patch.
> Also on LUCENE-5189, Rob raised a concern about SegmentInfo.attributes that have same
limitation -- if a Codec modifies them, they are silently being ignored, since we don't gen
the .si files. I think we can easily solve that by recording SI.attributes in SegmentInfos,
so they are recorded per-commit. But I think it should be handled in a separate issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message