lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5210) Unit tests for LicenseCheckTask.
Date Mon, 16 Sep 2013 03:00:52 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768019#comment-13768019
] 

Robert Muir commented on LUCENE-5210:
-------------------------------------

I have no opinion on the eclipse/ant/antunit stuff.

I just want to say currently there is no test, so I think we should start with a test and
then improve it.

My one suggestion about testing and the jars: if the test is in java, it can easily create
jars on the fly in temp dirs so we dont have to package them (with fake licenses). This is
done in ResourceLoaderTest in solr for example:

{code}
  public void testClassLoaderLibs() throws Exception {
    File tmpRoot = _TestUtil.getTempDir("testClassLoaderLibs");

    File lib = new File(tmpRoot, "lib");
    lib.mkdirs();

    JarOutputStream jar1 = new JarOutputStream(new FileOutputStream(new File(lib, "jar1.jar")));
    jar1.putNextEntry(new JarEntry("aLibFile"));
    jar1.closeEntry();
    jar1.close();
    ...
{code}

                
> Unit tests for LicenseCheckTask.
> --------------------------------
>
>                 Key: LUCENE-5210
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5210
>             Project: Lucene - Core
>          Issue Type: Test
>          Components: general/build
>            Reporter: Mark Miller
>         Attachments: LUCENE-5210.patch, LUCENE-5210.patch
>
>
> While working on LUCENE-5209, I noticed the LicenseCheckTask is kind of a second class
citizen - excluded from UI src folder setup and with no units tests. This was a little scary
to me.
> I've started adding some units tests. So far I have mainly just done the lifting of getting
units tests to work as part of tools.
> I have added two super simple tests - really just the start - but something to build
on.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message