lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-5150) HdfsIndexInput may not fully read requested bytes.
Date Mon, 16 Sep 2013 14:59:01 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768381#comment-13768381
] 

Mark Miller commented on SOLR-5150:
-----------------------------------

I'm just going to commit the current fix and worry about any performance improvements in another
issue.
                
> HdfsIndexInput may not fully read requested bytes.
> --------------------------------------------------
>
>                 Key: SOLR-5150
>                 URL: https://issues.apache.org/jira/browse/SOLR-5150
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.4
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-5150.patch
>
>
> Patrick Hunt noticed that our HdfsDirectory code was a bit behind Blur here - the read
call we are using may not read all of the requested bytes - it returns the number of bytes
actually written - which we ignore.
> Blur moved to using a seek and then readFully call - synchronizing across the two calls
to deal with clones.
> We have seen that really kills performance, and using the readFully call that lets you
pass the position rather than first doing a seek, performs much better and does not require
the synchronization.
> I also noticed that the seekInternal impl should not seek but be a no op since we are
seeking on the read.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message