lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5157) Refactoring MultiDocValues.OrdinalMap to clarify API and internal structure.
Date Thu, 08 Aug 2013 17:15:48 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733701#comment-13733701
] 

Adrien Grand commented on LUCENE-5157:
--------------------------------------

I discussed about this issue with Robert to see how we can move forward:
 - moving OrdinalMap to MultiTermsEnum can be controversial as Robert explained so let's only
tackle the naming and getSegmentOrd API issues here,
 - another option to make getSegmentOrd less trappy is to add an assertion that the provided
segment number is the same as the one returned by {{getSegmentNumber}}, this would allow for
returning the segment ordinals on any segment in the future without changing the API,
 - renaming subIndex to segment is ok as it makes the naming more consistent.

Robert, please correct me if you think it doesn't reflect correctly what we said.
Boaz, what do you think?
                
> Refactoring MultiDocValues.OrdinalMap to clarify API and internal structure.
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-5157
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5157
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Boaz Leskes
>            Priority: Minor
>         Attachments: LUCENE-5157.patch
>
>
> I refactored MultiDocValues.OrdinalMap, removing one unused parameter and renaming some
methods to more clearly communicate what they do. Also I renamed subIndex references to segmentIndex.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message