lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] [Updated] (SOLR-5108) plugin loading should fail if mor then one instance of a singleton plugin is found
Date Mon, 19 Aug 2013 21:43:49 GMT


Hoss Man updated SOLR-5108:

    Attachment: SOLR-5108.patch


* requires usage of loadPluginInfo to specify if multiple PluginInfo instances are expected
else error
* makes getPluginInfo fail if multiple PluginInfo instances exist
* adds a test for a good error if multiple instances of directoryFactory are found (as an
* fixes a bug in solrconfig-test-misc.xml that actually did have redundent directoryFactories

> plugin loading should fail if mor then one instance of a singleton plugin is found
> ----------------------------------------------------------------------------------
>                 Key: SOLR-5108
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: SOLR-5108.patch
> Continuing from the config parsing/validation work done in SOLR-4953, we should improve
SolrConfig so that parsing fails if multiple instances of a "plugin" are found for types of
plugins where only one is allowed to be used at a time.
> at the moment, {{SolrConfig.loadPluginInfo}} happily initializes a {{List<PluginInfo>}}
for whatever xpath it's given, and then later code can either call {{List<PluginInfo>
getPluginInfos(String)}} or {{PluginInfo getPluginInfo(String)}} (the later just being shorthand
for getting the first item in the list.
> we could make {{getPluginInfo(String)}} throw an error if the list has multiple items,
but i think we should also change the signature of {{loadPluginInfo}} to be explicit about
how many instances we expect to find, so we can error earlier, and have a redundant check.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message