lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-5094) TestJmxIntegration makes no sense
Date Tue, 30 Jul 2013 21:59:48 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724487#comment-13724487
] 

ASF subversion and git services commented on SOLR-5094:
-------------------------------------------------------

Commit 1508661 from hossman@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1508661 ]

SOLR-5094: Fix order of setup in TestJmxIntegration so MBean server is running before Solr
init.  Also fixes SOLR-4418
                
> TestJmxIntegration makes no sense
> ---------------------------------
>
>                 Key: SOLR-5094
>                 URL: https://issues.apache.org/jira/browse/SOLR-5094
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: SOLR-5094.patch
>
>
> for reasons i can't explain, TestJmxIntegration stoped working on my machine today, and
when i started looking into it, i realized that there's no logical reason why it should be
working on any machine at all.
> Back when this test was first written, it was setup to ensure that an MBean server was
up and running prior to initializing the SolrCore, and then the configuration used by the
test was designed to use JMX if and only if an existing MBean server was running.
> in [r1402613|https://svn.apache.org/viewvc?view=revision&revision=1402613] this was
(inadvertantly?) changed so that the SolrCore was initialized @BeforeClass, but there was
no certainty that the Mbean server was started until later -- so the test fails in a variety
of confusing ways because there is no JMX running at all.  The only reason it can succeed
is if an MBean server already happens to be running.
> I've got a patch that should fix this in general, or at least make it fail with a clear
error if hte problem is that a JMX server isn't found on core init

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message