lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5116) IW.addIndexes doesn't prune all deleted segments
Date Fri, 19 Jul 2013 12:24:49 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713603#comment-13713603
] 

Robert Muir commented on LUCENE-5116:
-------------------------------------

{quote}
asserting there are no empty segments. But I'm not sure we should, because technically it's
not an error. I.e. you could do new IW().commit() and it's a perfectly valid index.
{quote}

Wait: I still think we need to. Ill open an issue and take care of it.

The difference is: new IW().commit() should make a "empty commit" (segments_N with no segments).
Not a 0 document segment...
                
> IW.addIndexes doesn't prune all deleted segments
> ------------------------------------------------
>
>                 Key: LUCENE-5116
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5116
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Shai Erera
>             Fix For: 5.0, 4.5
>
>         Attachments: LUCENE-5116.patch, LUCENE-5116_test.patch
>
>
> at the least, this can easily create segments with maxDoc == 0.
> It seems buggy: elsewhere we prune these segments out, so its expected to have a commit
point with no segments rather than a segment with 0 documents...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message