lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4948) Tidy up CoreContainer construction logic
Date Sat, 06 Jul 2013 19:57:48 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701399#comment-13701399
] 

Uwe Schindler commented on SOLR-4948:
-------------------------------------

Thanks! Commit looks fine, I think Windows tests will succeed also on 4.x :-)
                
> Tidy up CoreContainer construction logic
> ----------------------------------------
>
>                 Key: SOLR-4948
>                 URL: https://issues.apache.org/jira/browse/SOLR-4948
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: SOLR-4948.patch, SOLR-4948.patch, SOLR-4948.patch, SOLR-4948.patch,
SOLR-4948.patch, SOLR-4948.patch, SOLR-4948.patch
>
>
> While writing tests for SOLR-4914, I discovered that it's *really difficult* to create
a CoreContainer.  There are a bunch of constructors which initialise different things, one
(but only one!) of which also loads all the cores.  Then you have the Initializer object,
which basically does the same thing.  Sort of.  And then the TestHarness doesn't actually
use CoreContainer, but an anonymous subclass of CoreContainer which has it's own initialisation
logic.  It would be nice to clean this up!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message