lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Otis Gospodnetic (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-3583) Percentiles for facets, pivot facets, and distributed pivot facets
Date Tue, 02 Jul 2013 02:56:22 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697441#comment-13697441
] 

Otis Gospodnetic edited comment on SOLR-3583 at 7/2/13 2:54 AM:
----------------------------------------------------------------

That's a meaty 81K patch and juicy new functionality that, if I'm reading this right, actually
works with SolrCloud?
Solr 4.4 is in the works and it would be nice to get this in.

[~andrew.muldowney] & [~selah] - I see a few new classes there.  Could you please add
ASL to them?
Could you please re-indent to match the rest of the code?  I think the rest of the code uses
2 spaces...

Maybe also change stuff like:
{code}
if(PivotFacetHelper.getStatistics(toAddsPivotInfoClone)!=null){
{code}

to
{code}
if (PivotFacetHelper.getStatistics(toAddsPivotInfoClone) != null ) {
{code}

This will make it easier to read/review.  Thanks!
                
      was (Author: otis):
    That's a meaty 81K patch and juicy new functionality that, if I'm reading this right,
actually works with SolrCloud?

[~andrew.muldowney] & [~selah] - I see a few new classes there.  Could you please add
ASL to them?
Could you please re-indent to match the rest of the code?  I think the rest of the code uses
2 spaces...

Maybe also change stuff like:
{code}
if(PivotFacetHelper.getStatistics(toAddsPivotInfoClone)!=null){
{code}

to
{code}
if (PivotFacetHelper.getStatistics(toAddsPivotInfoClone) != null ) {
{code}

This will make it easier to read/review.  Thanks!
                  
> Percentiles for facets, pivot facets, and distributed pivot facets
> ------------------------------------------------------------------
>
>                 Key: SOLR-3583
>                 URL: https://issues.apache.org/jira/browse/SOLR-3583
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Chris Russell
>            Priority: Minor
>              Labels: newbie, patch
>             Fix For: 4.4
>
>         Attachments: SOLR-3583.patch, SOLR-3583.patch, SOLR-3583.patch, SOLR-3583.patch
>
>
> Built on top of SOLR-2894, this patch adds percentiles and averages to facets, pivot
facets, and distributed pivot facets by making use of range facet internals.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message