lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Han Jiang (JIRA)" <>
Subject [jira] [Updated] (LUCENE-5028) doShare is pointless in PositiveIntOutputs
Date Sat, 01 Jun 2013 07:44:20 GMT


Han Jiang updated LUCENE-5028:

    Attachment: LUCENE-5028.patch

the second patch also removes a silly equal check in PositiveIntOutputs
> doShare is pointless in PositiveIntOutputs
> ------------------------------------------
>                 Key: LUCENE-5028
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/FSTs
>            Reporter: Han Jiang
>            Assignee: Han Jiang
>            Priority: Minor
>             Fix For: 5.0
>         Attachments: LUCENE-5028.patch, LUCENE-5028.patch
> We recently use this in oal.core.fst.PositiveIntOutputs to indicate whether to share
outputs. The comment mentioned 'with doShare=false, in some case this may result in a smaller
FST'. However, this is not intuitive, as for long type, we always have the smallest output
reduced to NO_OUTPUT, thus the smallest one is 'moved' towards root, and no extra output is
> However, if there are many many small outputs around root arcs, when we share outputs,
a large output might be pushed into the root arcs. When root arcs are packed as fixed-array,
yes the size of FST is increased. But, I suppose this should invoke other intuitive heuristics,
instead of the confusing 'doShare'?
> Besides, this only exist in PositiveIntOutputs.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message