lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-4858) updateLog + core reload + deleteByQuery = leaked directory
Date Fri, 31 May 2013 12:52:21 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671412#comment-13671412
] 

Mark Miller edited comment on SOLR-4858 at 5/31/13 12:51 PM:
-------------------------------------------------------------

bq. deletionPolicy sharing could have something to do with this, given that it doesn't seem
like Solr's original deletion policy was meant to be shared by multiple writers?

It actually wans't intended to be shared across new writers - in the above mentioned issues,
it's still the same writer.

We did recently add a call to create a new index writer on reload though -- and on a closer
look, that ends up passing the old deletion policy to the new writer. Perhaps we should look
at that - it looks like it uses a couple data structures that perhaps should be created fresh
and not passed on (DefaultSolrCoreState#createMainIndexWriter).
                
      was (Author: markrmiller@gmail.com):
    bq. deletionPolicy sharing could have something to do with this, given that it doesn't
seem like Solr's original deletion policy was meant to be shared by multiple writers?

It actually wans't intended to be shared across new writers - in the above mentioned issues,
it's still the new writer.

We did recently add a call to create a new index writer on reload though -- and on a closer
look, that ends up passing the old deletion policy to the new writer. Perhaps we should look
at that - it looks like it uses a couple data structures that perhaps should be created fresh
and not passed on (DefaultSolrCoreState#createMainIndexWriter).
                  
> updateLog + core reload + deleteByQuery = leaked directory
> ----------------------------------------------------------
>
>                 Key: SOLR-4858
>                 URL: https://issues.apache.org/jira/browse/SOLR-4858
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.2.1
>            Reporter: Hoss Man
>             Fix For: 4.3.1
>
>         Attachments: SOLR-4858.patch, SOLR-4858.patch, SOLR-4858.patch
>
>
> I havene't been able to make sense of this yet, but trying to track down another bug
lead me to discover that the following combination leads to problems...
> * updateLog enabled
> * do a core reload
> * do a delete by query \*:\*
> ...leave out any one of the three, and everything works fine.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message