lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4973) SnapshotDeletionPolicy should not require an id
Date Wed, 01 May 2013 20:12:16 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646880#comment-13646880
] 

Shai Erera commented on LUCENE-4973:
------------------------------------

+1. I will review the patch tomorrow, but I think pSDP needs to have a getIC(gen) because
if the apps persists the gens, it needs a way to obtain their IC instance.

bq. I think separately we should fix PersistentSDP to store its state in a single file ...
separate issue.

+1! would be great if this can be in the index directory, so that app doesn't need to make
up locations. but let's discuss that separately.
                
> SnapshotDeletionPolicy should not require an id
> -----------------------------------------------
>
>                 Key: LUCENE-4973
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4973
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.0, 4.4
>
>         Attachments: LUCENE-4973.patch
>
>
> The id is unnecessary and just adds complexity: SDP can just return
> the IndexCommit, and when you want to release you pass back the
> IndexCommit.  PersistentSDP can expose release(long gen).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message