Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB169F090 for ; Fri, 5 Apr 2013 16:41:17 +0000 (UTC) Received: (qmail 45622 invoked by uid 500); 5 Apr 2013 16:41:16 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 45552 invoked by uid 500); 5 Apr 2013 16:41:16 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 45544 invoked by uid 99); 5 Apr 2013 16:41:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Apr 2013 16:41:16 +0000 Date: Fri, 5 Apr 2013 16:41:16 +0000 (UTC) From: "Commit Tag Bot (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-4899) FastVectorHighlihgter fails with SIOOB if single phrase or term is > fragCharSize MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-4899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623773#comment-13623773 ] Commit Tag Bot commented on LUCENE-4899: ---------------------------------------- [trunk commit] simonw http://svn.apache.org/viewvc?view=revision&revision=1465032 LUCENE-4899: FastVectorHighlihgter failed with StringIndexOutOfBoundsException if a single highlight phrase or term was greater than the fragCharSize producing negative string offsets > FastVectorHighlihgter fails with SIOOB if single phrase or term is > fragCharSize > --------------------------------------------------------------------------------- > > Key: LUCENE-4899 > URL: https://issues.apache.org/jira/browse/LUCENE-4899 > Project: Lucene - Core > Issue Type: Bug > Components: modules/highlighter > Affects Versions: 4.0, 4.1, 4.2, 3.6.2, 4.2.1 > Reporter: Simon Willnauer > Fix For: 5.0, 4.3 > > Attachments: LUCENE-4899.patch, LUCENE-4899.patch > > > This has been reported on several occasions like SOLR-4660 / SOLR-4137 or on the ES mailing list https://groups.google.com/d/msg/elasticsearch/IdyMSPK5gao/nKZq8_NYWmgJ > The reason is that the current code expects the fragCharSize > matchLength which is not necessarily true if you use phrases or if you have very long terms like URLs or so. I have a test that reproduces the issue and a fix as far as I can tell (me doesn't have much experience with the highlighter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org