Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Mon, 1 Apr 2013 10:41:16 +0000 (UTC)
From: "Steve Rowe (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.12638770.1364173632108.84899.1364812876744@arcas>
In-Reply-To: <JIRA.12638770.1364173632108@arcas>
References: <JIRA.12638770.1364173632108@arcas>
Subject: [jira] [Commented] (LUCENE-4877) Fix analyzer factories to throw
 exception when arguments are invalid
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618736#comment-13618736 ] 

Steve Rowe commented on LUCENE-4877:
------------------------------------

{quote}
bq. Should we create a branch. I also have some ideas to fix...

We can, or maybe just use trunk? I don't think the patch makes these factories any worse.
{quote}

+1 to commit Robert's patch to trunk and iterate there.
                
> Fix analyzer factories to throw exception when arguments are invalid
> --------------------------------------------------------------------
>
>                 Key: LUCENE-4877
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4877
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/analysis
>            Reporter: Robert Muir
>         Attachments: LUCENE-4877_one_solution_prototype.patch, LUCENE-4877.patch, LUCENE-4877.patch, LUCENE-4877.patch
>
>
> Currently if someone typos an argument "someParamater=xyz" instead of someParameter=xyz, they get no exception and sometimes incorrect behavior.
> It would be way better if these factories threw exception on unknown params, e.g. they removed the args they used and checked they were empty at the end.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org