lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Commit Tag Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4768) The Solr war produced by generate-maven-artifacts should not contain logging jars
Date Fri, 26 Apr 2013 19:36:16 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643165#comment-13643165
] 

Commit Tag Bot commented on SOLR-4768:
--------------------------------------

[lucene_solr_4_3 commit] sarowe
http://svn.apache.org/viewvc?view=revision&revision=1476353

SOLR-4768: The Solr war produced by generate-maven-artifacts should not contain logging jars
(merged trunk r1476237)
                
> The Solr war produced by generate-maven-artifacts should not contain logging jars
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-4768
>                 URL: https://issues.apache.org/jira/browse/SOLR-4768
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 4.3
>            Reporter: Steve Rowe
>            Assignee: Steve Rowe
>
> I know why the two .wars are different:
> The binary package Solr war's target chain is:
>   {noformat}'package'->'create-package'->'dist'->'dist-war'->webapp:'dist'{noformat}
> The maven Solr war's target chain is:
>   {noformat}'generate-maven-artifacts'->webapp:'dist-maven'->webapp:'dist'{noformat}
> So both create the war using webapp:'dist', but only 'dist-war' passes in a modified
'exclude.from.war' property definition (which is empty by default):
>   {code:xml}<property name="exclude.from.war" value="*slf4j*,log4j-*" />{code}
> As a result, the maven Solr war contains logging jars while the official war does not.
> I think the fix is to make the above the default setting, rather than passing in a non-default
property value from 'dist-war'.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message