lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4766) smoketester to check war files have the same contents
Date Fri, 26 Apr 2013 17:52:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643067#comment-13643067
] 

Steve Rowe commented on SOLR-4766:
----------------------------------

I ran the Maven checks from the smoke tester with Mike's modifications against the 4.1 and
the 4.2 RCs (each had only one).

The checks against 4.1 failed because the Maven Solr war has this:

    WEB-INF/lib/solr-solrj-4.1.0.jar [384476 bytes]

while the binary Solr war has this:

    WEB-INF/lib/solr-solrj-4.1.0.jar [384475 bytes]

So apparently the timestamp metadata can change file sizes in practice, not just in theory.
 I think we should remove the file size checks from smoke tester's maven/binary war file contents
comparison.

-----
The 4.2 check failed with a different message:

RuntimeError: JAR file "/Users/sarowe/temp/4.2/tmpDir/maven/org/apache/lucene/lucene-analyzers-common/4.2.0/lucene-analyzers-common-4.2.0-javadoc.jar"
is missing "Created-By: 1.6" inside its META-INF/MANIFEST.MF

The Created-By line from lucene-analyzers-common's manifest is:

Created-By: 1.7.0_09-b05 (Oracle Corporation)


                
> smoketester to check war files have the same contents
> -----------------------------------------------------
>
>                 Key: SOLR-4766
>                 URL: https://issues.apache.org/jira/browse/SOLR-4766
>             Project: Solr
>          Issue Type: Test
>          Components: Build
>    Affects Versions: 4.3
>            Reporter: Robert Muir
>             Fix For: 5.0, 4.4
>
>
> As Ryan points out on "[VOTE] Lucene Solr 4.3.0 RC3" thread, somehow the .war file in
the binary packaging has different contents than the maven one (in particular, one contains
logging jars, the other does not).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message