lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-4725) Should we stop supporting "name" and "dataDir" in the autodiscover mode?
Date Wed, 17 Apr 2013 03:13:15 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633709#comment-13633709
] 

Mark Miller edited comment on SOLR-4725 at 4/17/13 3:12 AM:
------------------------------------------------------------

Okay, wait - you don't mean dataDir in solrconfig.xml.

In that case, I'm confused...was their explicit support for dataDir in solr.xml before? I
thought it was just basic property support so that if you setup solrconfig.xml to take a prop
substitution, you could then set those properties in solr.xml with the generic <property
setting. We don't need those anymore I think.

Anyway, there doesn't need to be anything specific to the dataDir at the solr.xml level -
that should be handled in solrconfig.xml.

                
      was (Author: markrmiller@gmail.com):
    Okay, wait - you don't mean dataDir in solrconfig.xml.

In that case, I'm confused...was their explicit support for dataDir in solr.xml before? I
thought it was just basic property support so that if you setup solrconfig.xml to take a prop
substitution, you could then set those properties in solr.xml with the generic <property
setting. We don't need those anymore I think.

Anyway, there doesn't need to be anything specific to the dataDir at the solrconfig.xml level
- that should be handled in solrconfig.xml.

- Mark
                  
> Should we stop supporting "name" and "dataDir" in the autodiscover mode?
> ------------------------------------------------------------------------
>
>                 Key: SOLR-4725
>                 URL: https://issues.apache.org/jira/browse/SOLR-4725
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.3, 5.0
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Blocker
>
> Making this a blocker so we resolve it. Should be quick to code if we have consensus,
maybe nothing at all to do here.
> I'm not too happy with the fact that the new core discovery process has two real gotcha's.
The individual core.properties file can define 'name' and 'dataDir'. It seems too easy to
either use the same name for two different cores or use the same dataDir, just copy the core.properties
file around and fail to edit one them. In large installations this could be a bear to track
down.
> Straw-man proposal is the we remove support for them both in discovery mode. The name
defaults to the directory in which core.properties is found and the data dir is immediately
below there.
> Currently, there are checks to fail to load either core if either 'name' or 'dataDir'
is defined in more than one core. I think the error reporting is weak, you probably have to
look in the log file and there should be a way to get this in the admin UI at least.
> Maybe the right thing to do is just leave it as-is and emphasize that specifying the
dataDir and name is expert level and you have to get it right, but I wanted to get wider exposure
to the problem before we push 4.3 out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message