lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4723) sort order different in branch_4x than trunk
Date Tue, 16 Apr 2013 21:01:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633352#comment-13633352
] 

Robert Muir commented on SOLR-4723:
-----------------------------------

It might be that trunk uses Double.compare (from a java7 commit?) and branch_4x does this:

{code}
if (v1 > v2) {
  return 1;
} else if (v1 < v2) {
  return -1;
} else {
  return 0;
}
{code}

If so this is not right, because NumericUtils documents it is consistent with Double.compareTo
and Float.compareTo, so something needs to be fixed.
                
> sort order different in branch_4x than trunk
> --------------------------------------------
>
>                 Key: SOLR-4723
>                 URL: https://issues.apache.org/jira/browse/SOLR-4723
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: SOLR-4723_test.patch
>
>
> I will buy a beer to whoever figures out why +0 sorts before -0 in branch_4x, but works
correctly in trunk :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message