lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4697) add 'zkHost="${zkHost}"' to example solr.xml and deprecate hardcoded check for zkHost system property
Date Wed, 10 Apr 2013 01:27:13 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627354#comment-13627354
] 

Mark Miller commented on SOLR-4697:
-----------------------------------

bq. regardless of how much of what is currently in solr.xml that we can push into zk, the
basic information of "what zookeeper machines should i talk to" still needs to be something
we tell the machine so it can go talk to zk and get all it's details

The fastest and most consistent route to getting solr.xml in zookeeper is to put it there
- just like solrconfig.xml. Diverging too much too fast from non solrcloud mode needs to be
considered carefully. It's not clear how the two modes will shake out. For now, it makes sense
for core and system settings to be consistent.

bq. 2)

zkhost can't go in solr.xml - if you want to make a new config file for it to alleviate sys
prop short falls, that's fine - there is likely another param or two that can go there - but
it shouldn't go in solr.xml - almost all of that can go straight to zk right now and that
will just bog it down - it's the wrong direction.

bq. we should not completely eliminate the ability for multiple solr instances running in
a single servlet container

I have no interest in supporting multiple instances running in a single container, so I won't
add anything of value here.
                
> add 'zkHost="${zkHost}"' to example solr.xml and deprecate hardcoded check for zkHost
system property
> -----------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4697
>                 URL: https://issues.apache.org/jira/browse/SOLR-4697
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>
> Similar to the work done in SOLR-4622 related to hostContext and hostPort, we should
do a better job of advertising the zkHost setting in solr.xml and deprecate the explicit check
for a zkHost property in SolrCore.initZooKeeper -- so that it still works in 4.x with a warning,
but in 5.0 zkHost must be specified in solr.xml, even if it's just to refer to a sys property
with the same name

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message