lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4697) add 'zkHost="${zkHost}"' to example solr.xml and deprecate hardcoded check for zkHost system property
Date Wed, 10 Apr 2013 01:19:13 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627346#comment-13627346
] 

Hoss Man commented on SOLR-4697:
--------------------------------

When i initially proposed this in SOLR-4622 miller commented...

bq. I think zkHost will likely fall out of solr.xml so that we can put those in zk. I think
we really want to get system settings in the cloud just like core settings. It's fairly annoying
now that to make many changes you need to update solr.xml on every node.

while i can understand the motivation here, i still can't imagine a day when there is nothing
like a slimmed down solr.xml that sits outside of zk...

1) regardless of how much of what is currently in solr.xml that we can push into zk, the basic
information of "what zookeeper machines should i talk to" still needs to be something we tell
the machine so it can go talk to zk and get all it's details

2) even if we generally encourage people to use system properties to specify things like zkHost
(and hostContext, and hostPort) those sysproperties should generally just be used as substitutions
into solr.xml (or whatever replaces it) for all the same reasons already mentioned in SOLR-4622:
having them in the configs makes them self documenting for users who aren't familiar with
the java code to to understand where they are coming from.

3) we should not completely eliminate the ability for multiple solr instances running in a
single servlet container to be a part of distinct solr clouds -- which they would need to
be if the only way to specific zkHost was a system property, since that would prevent them
from using a different zk chroot

                
> add 'zkHost="${zkHost}"' to example solr.xml and deprecate hardcoded check for zkHost
system property
> -----------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4697
>                 URL: https://issues.apache.org/jira/browse/SOLR-4697
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>
> Similar to the work done in SOLR-4622 related to hostContext and hostPort, we should
do a better job of advertising the zkHost setting in solr.xml and deprecate the explicit check
for a zkHost property in SolrCore.initZooKeeper -- so that it still works in 4.x with a warning,
but in 5.0 zkHost must be specified in solr.xml, even if it's just to refer to a sys property
with the same name

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message