lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4676) Share a Lucene FieldType instance instead of creating on each call to createField()
Date Fri, 05 Apr 2013 16:31:15 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623762#comment-13623762
] 

Adrien Grand commented on SOLR-4676:
------------------------------------

{quote}
I agree with both of these statements. Can we remove createField() and eliminate this trap?
DocumentBuilder only calls createFields() and thats... the only thing that should be calling
this method?
{quote}

+1
                
> Share a Lucene FieldType instance instead of creating on each call to createField()
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-4676
>                 URL: https://issues.apache.org/jira/browse/SOLR-4676
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: SOLR-4676_Share_Lucene_FieldType_in_SchemaField.patch
>
>
> I think the Lucene FieldType instances should be cached on Solr's SchemaField so that
they don't have to be needlessly re-created for each indexed value that runs through Solr
in SchemaField.createField(). The only obstacle I see to this is that getIndexOptions(field,val)
takes the value, and if that value were to alter the logic then the FieldType can't be shared.
This is a protected method and I don't see anything that overrides it, and the default implementation
doesn't use the value. So I think it can be removed.  Patch in progress...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message