lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4896) PostingsHighlighter should use a interface of PassageFormatter instead of a class
Date Fri, 12 Apr 2013 18:28:16 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630444#comment-13630444
] 

Robert Muir commented on LUCENE-4896:
-------------------------------------

Thanks again Luca. I committed this with only one change to your patch (i added some javadocs
to append, since its now protected).

I'm backporting now and then i'll resolve the issue.
                
> PostingsHighlighter should use a interface of PassageFormatter instead of a class
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-4896
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4896
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>    Affects Versions: 4.2
>         Environment: NA
>            Reporter: Sebastien Dionne
>              Labels: newdev
>         Attachments: LUCENE-4896.patch, LUCENE-4896.patch, LUCENE-4896.patch
>
>
> In my project I need a custom PassageFormatter to use with PostingsHighlighter.  I extended
PassageFormatter  to override format(...)
> but if I do that, I don't have access to the private variables.  So instead of changing
the scope to protected, it should be more usefull to use a interface for PassageFormatter.
> like public DefaultPassageFormatter implements PassageFormatter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message