lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] [Updated] (LUCENE-4885) each FacetResult should return the facet equivalent of totalHits
Date Wed, 10 Apr 2013 19:03:16 GMT


Shai Erera updated LUCENE-4885:

    Attachment: LUCENE-4885.patch

While looking at the top-k-in-each-node code, I realized that FacetResult.numValidDescendants
is what we needed to use all along, and that new FacetsAccumulator code just incorrectly set
it to K, rather than total num children considered. I added a test to TestFacetsCollector
and fixed the code. So actually this issue turned from a new feature to a bug :).

Mike, thanks for doing the work to add it to FRN, it made the fix very easy - I just pulled
it to FacetResult instead. All the tests that you added helped validate the fix.

I think it's ready.
> each FacetResult should return the facet equivalent of totalHits
> ----------------------------------------------------------------
>                 Key: LUCENE-4885
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>              Labels: newdev
>             Fix For: 5.0, 4.3
>         Attachments: LUCENE-4885.patch, LUCENE-4885.patch, LUCENE-4885.patch
> This is cheap to compute, since the TopKFRH already must visit all non-zero-count ords
under the FacetRequest.categoryPath.
> This can be useful to a front end, eg to know whether to present a "More..." under that
dimension or not, whether to use a suggester like LinkedIn's facet UI, etc.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message