lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Rowe (JIRA)" <>
Subject [jira] [Updated] (LUCENE-4877) Fix analyzer factories to throw exception when arguments are invalid
Date Mon, 01 Apr 2013 18:13:16 GMT


Steve Rowe updated LUCENE-4877:

    Attachment: LUCENE-4877-steve-minor-fixes.patch

Patch fixing these minor nits:

TestMappingCharFilterFactory's factory could switch to being instantiated using the charFilterFactory()
EdgeNgramTokenizerFactory's gram size constants are pulled from EdgeNgramTokenFilter instead
of EdgeNgramTokenizer
LimitTokenCountFilterFactory's maxTokenCount param should be required; this is a pre-existing
problem though
PatternTokenizerFactory's group param should use the getInt() method with a default of -1.

Actually, I was wrong about LimitTokenCountFilterFactory - it already has a test in place
to insure reporting of missing required maxTokenCount param.

Committing shortly.

> Fix analyzer factories to throw exception when arguments are invalid
> --------------------------------------------------------------------
>                 Key: LUCENE-4877
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/analysis
>            Reporter: Robert Muir
>         Attachments: LUCENE-4877_one_solution_prototype.patch, LUCENE-4877.patch, LUCENE-4877.patch,
LUCENE-4877.patch, LUCENE-4877-steve-minor-fixes.patch
> Currently if someone typos an argument "someParamater=xyz" instead of someParameter=xyz,
they get no exception and sometimes incorrect behavior.
> It would be way better if these factories threw exception on unknown params, e.g. they
removed the args they used and checked they were empty at the end.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message