lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4586) Increase default maxBooleanClauses
Date Thu, 04 Apr 2013 23:36:17 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622994#comment-13622994
] 

Yonik Seeley commented on SOLR-4586:
------------------------------------

bq. (I fundamentally disagree with the entire idea of just letting things be "slow" instead
of catching errors).

It's extremely "trappy" to fail hard at a low arbitrary limit (and it's silly calling it an
error if it goes above that limit).
maxBooleanClauses should be removed from Solr (or effectively removed via setting it to MAX_INT)
provided there are no bugs in Lucene that create any priority queues of this size.


bq. All other code for maxBooleanClauses is gone.

+1
                
> Increase default maxBooleanClauses
> ----------------------------------
>
>                 Key: SOLR-4586
>                 URL: https://issues.apache.org/jira/browse/SOLR-4586
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.2
>         Environment: 4.3-SNAPSHOT 1456767M - ncindex - 2013-03-15 13:11:50
>            Reporter: Shawn Heisey
>         Attachments: SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch
>
>
> In the #solr IRC channel, I mentioned the maxBooleanClauses limitation to someone asking
a question about queries.  Mark Miller told me that maxBooleanClauses no longer applies, that
the limitation was removed from Lucene sometime in the 3.x series.  The config still shows
up in the example even in the just-released 4.2.
> Checking through the source code, I found that the config option is parsed and the value
stored in objects, but does not actually seem to be used by anything.  I removed every trace
of it that I could find, and all tests still pass.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message