lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3251) dynamically add field to schema
Date Thu, 04 Apr 2013 22:00:16 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622860#comment-13622860
] 

Robert Muir commented on SOLR-3251:
-----------------------------------

Its bugs of a different form.

If you make the schema mutable, then now you have a "mutable" Codec that indexwriter is using.
This could cause a lot of issues: there is a reason why Codec is 'final' on indexwriter. Other
similar strange bugs can suddenly pop out, i'm just mentioning one.

I dont think the schema should be mutable. I think it would be less crazy if it was already
mutable, but given that its already immutable, if we want to make this change then there needs
to be a lot of review and discussion about what *will* break.

as far as the issue being open for over a year with little discussion, i dont care about that.
yesterday a patch when up that made the schema mutable, where the previous discussion before
that patch indicated it might be copy-on-write or something else (immutable). I saw yonik's
comment yesterday about immutability and started thinking about what all could go wrong here
unless we go that route (it seems to me: a lot).

I figured yesterday i wouldnt need to comment, that the issue would probably go that direction
anyway. However today when you mentioned you wanted to commit it, it surprised me, so i spoke
up.


                
> dynamically add field to schema
> -------------------------------
>
>                 Key: SOLR-3251
>                 URL: https://issues.apache.org/jira/browse/SOLR-3251
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Steve Rowe
>         Attachments: SOLR-3251.patch, SOLR-3251.patch
>
>
> One related piece of functionality needed for SOLR-3250 is the ability to dynamically
add a field to the schema.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message