lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3538) fix java7 warnings in the source code
Date Thu, 04 Apr 2013 13:35:15 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622193#comment-13622193
] 

Robert Muir commented on LUCENE-3538:
-------------------------------------

Hi Furkan, thanks for looking into this. I get a couple warnings when running the following
commands with a java7 compiler:

I'm using "1.7.0_17"

{noformat}
svn co https://svn.apache.org/repos/asf/lucene/dev/trunk
cd trunk/lucene
ant compile > ../compile.log
{noformat}

lucene/analysis/common module:
{noformat}
    [javac] Compiling 360 source files to /home/rmuir/workspace/lucene-trunk/lucene/build/analysis/common/classes/java
    [javac] /home/rmuir/workspace/lucene-trunk/lucene/analysis/common/src/java/org/tartarus/snowball/Among.java:46:
warning: [rawtypes] found raw type: Class
    [javac]   private static final Class<?>[] EMPTY_PARAMS = new Class[0];
    [javac]                                                      ^
    [javac]   missing type arguments for generic class Class<T>
    [javac]   where T is a type-variable:
    [javac]     T extends Object declared in class Class
...

{noformat}

lucene/queries:
lots of warnings unfortunately
{noformat}
    [javac]   missing type arguments for generic class Map<K,V>
    [javac]   where K,V are type-variables:
    [javac]     K extends Object declared in interface Map
    [javac]     V extends Object declared in interface Map
    [javac] /home/rmuir/workspace/lucene-trunk/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/QueryValueSource.java:54:
warning: [rawtypes] found raw type: Map
    [javac]   public FunctionValues getValues(Map fcontext, AtomicReaderContext readerContext)
throws IOException {
{noformat}

lucene/queryparser:
again lots of warnings, some are in generated code which is more difficult, but also some
silly ones, like:
{noformat}
    [javac] /home/rmuir/workspace/lucene-trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/processors/GroupQueryNodeProcessor.java:54:
warning: [dep-ann] deprecated item is not annotated with @Deprecated
    [javac] public class GroupQueryNodeProcessor implements QueryNodeProcessor {
{noformat}

lucene/memory, lucene/highlighter, lucene/benchmark, and lucene/spatial also have warnings
too.



                
> fix java7 warnings in the source code
> -------------------------------------
>
>                 Key: LUCENE-3538
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3538
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>              Labels: newdev
>
> Now that oracle has fixed java7 bugs, I imagine some users will want to use it.
> Currently if you compile lucene's code with java7 you get a ton of warnings... lets clean
this up

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message