lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomás Fernández Löbbe (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-2079) Expose HttpServletRequest object from SolrQueryRequest object
Date Fri, 19 Apr 2013 18:23:15 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636690#comment-13636690
] 

Tomás Fernández Löbbe commented on SOLR-2079:
---------------------------------------------

Yes, I first thought about adding just the headers but that would mean that the value of each
header was going to be always an Enumeration<String>, which would require to iterate,
even when only one value is expected for a header key, so I thought it was going to be better
to just add the request object, and then the custom components could use getHeader(String)
or getHeaders(String) depending on the needs, will make the component code cleaner. 
                
> Expose HttpServletRequest object from SolrQueryRequest object
> -------------------------------------------------------------
>
>                 Key: SOLR-2079
>                 URL: https://issues.apache.org/jira/browse/SOLR-2079
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers, search
>            Reporter: Chris A. Mattmann
>             Fix For: 4.3
>
>         Attachments: SOLR-2079.patch, SOLR-2079.patch, SOLR-2079.patch, SOLR-2079.Quach.Mattmann.082310.patch.txt
>
>
> This patch adds the HttpServletRequest object to the SolrQueryRequest object. The HttpServletRequest
object is needed to obtain the client's IP address for geotargetting, and is part of the patches
from W. Quach and C. Mattmann.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message