Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Tue, 19 Mar 2013 15:37:15 +0000 (UTC)
From: "Mark Miller (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.12637559.1363622426583.11679.1363707435613@arcas>
In-Reply-To: <JIRA.12637559.1363622426583@arcas>
References: <JIRA.12637559.1363622426583@arcas>
Subject: [jira] [Commented] (SOLR-4608) Update Log replay should use the
 default processor chain
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606411#comment-13606411 ] 

Mark Miller commented on SOLR-4608:
-----------------------------------

Report back soon and hopefully we can get this in 4.2.1.
                
> Update Log replay should use the default processor chain
> --------------------------------------------------------
>
>                 Key: SOLR-4608
>                 URL: https://issues.apache.org/jira/browse/SOLR-4608
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.1, 4.2
>            Reporter: ludovic Boutros
>            Assignee: Yonik Seeley
>             Fix For: 4.3, 5.0, 4.2.1
>
>         Attachments: SOLR-4608.patch
>
>
> If a processor chain is used with custom processors, 
> they are not used in case of node failure during log replay.
> Here is the code:
> {code:title=UpdateLog.java|borderStyle=solid}
>     public void doReplay(TransactionLog translog) {
>       try {
>         loglog.warn("Starting log replay " + translog + " active="+activeLog + " starting pos=" + recoveryInfo.positionOfStart);
>         tlogReader = translog.getReader(recoveryInfo.positionOfStart);
>         // NOTE: we don't currently handle a core reload during recovery.  This would cause the core
>         // to change underneath us.
>         // TODO: use the standard request factory?  We won't get any custom configuration instantiating this way.
>         RunUpdateProcessorFactory runFac = new RunUpdateProcessorFactory();
>         DistributedUpdateProcessorFactory magicFac = new DistributedUpdateProcessorFactory();
>         runFac.init(new NamedList());
>         magicFac.init(new NamedList());
>         UpdateRequestProcessor proc = magicFac.getInstance(req, rsp, runFac.getInstance(req, rsp, null));
> {code} 
> I think this is a big issue, because a lot of people will discover it when a node will crash in the best case... and I think it's too late.
> It means to me that processor chains are not usable with Solr Cloud currently.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org