Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Wed, 13 Mar 2013 00:37:12 +0000 (UTC)
From: "Robert Muir (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.12635867.1362683434196.429892.1363135032889@arcas>
In-Reply-To: <JIRA.12635867.1362683434196@arcas>
References: <JIRA.12635867.1362683434196@arcas>
Subject: [jira] [Commented] (LUCENE-4816) PassageFormatter in
 PostingsHighlighter trunk the message returned
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600660#comment-13600660 ] 

Robert Muir commented on LUCENE-4816:
-------------------------------------

Patch is good: i think I will look at this breakiterator as it is total evil (it will loop forever and never return Breakiterator.END) and see if it can be improved, but its not a huge deal.
                
> PassageFormatter in PostingsHighlighter trunk the message returned
> ------------------------------------------------------------------
>
>                 Key: LUCENE-4816
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4816
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/highlighter
>    Affects Versions: 4.1
>         Environment: NA
>            Reporter: Sebastien Dionne
>            Assignee: Michael McCandless
>         Attachments: BreakIteratorTest.java, LUCENE-4816.patch, package.html, PassageFormatter.java, PassageFormatter-PATCH.java, WholeBreakIterator.java
>
>
> when I try to highlight the word zero [0]  in the file : org\apache\lucene\search\postingshighlight\package.html
> the 2 last lines weren't return.  There are 4 Passages : 
> 2-65
> 277-434
> 434-735
> 735-968
> but the length of the file is 984.
> in the file : PassageFormatter.format(...)
> it should return all the original content with the words highlighted.
> PATCH
> need to add this at the end of the method
> // at line : 91 add this
> if(pos<content.length()){
>     sb.append(content.substring(pos));
> }
>     
> return sb.toString();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org