Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6E0B3F88A for ; Fri, 22 Mar 2013 16:33:21 +0000 (UTC) Received: (qmail 20290 invoked by uid 500); 22 Mar 2013 16:33:17 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 20220 invoked by uid 500); 22 Mar 2013 16:33:17 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 20182 invoked by uid 99); 22 Mar 2013 16:33:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Mar 2013 16:33:17 +0000 Date: Fri, 22 Mar 2013 16:33:17 +0000 (UTC) From: "Commit Tag Bot (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-4425) Unclear documentation of StoredFieldVisitor.binaryValue MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610744#comment-13610744 ] Commit Tag Bot commented on LUCENE-4425: ---------------------------------------- [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1390701 LUCENE-4425: Unclear documentation of StoredFieldVisitor.binaryValue > Unclear documentation of StoredFieldVisitor.binaryValue > ------------------------------------------------------- > > Key: LUCENE-4425 > URL: https://issues.apache.org/jira/browse/LUCENE-4425 > Project: Lucene - Core > Issue Type: Bug > Affects Versions: 4.0 > Reporter: Adrien Grand > Assignee: Robert Muir > Priority: Minor > Fix For: 4.0, 5.0 > > Attachments: LUCENE-4425.patch, LUCENE-4425.patch > > > When reading the binary value of a stored field, a StoredFieldsReader calls StoredFieldVisitor.binaryValue(arr, offset, length). > Documentation currently doesn't state whether the byte[] can be reused outside of the scope of {{StoredFieldVisitor.binaryValue}} but {{DocumentStoredFieldVisitor}} assumes (as of r1389812) that it can. > So {{DocumentStoredFieldVisitor}} would break with a custom {{StoredFieldsFormat}} that would call {{StoredFieldVisitor.binaryValue}} with a slice of a reusable buffer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org