Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Sat, 16 Mar 2013 18:54:12 +0000 (UTC)
From: "Erick Erickson (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.12413502.1233186687286.452466.1363460052758@arcas>
In-Reply-To: <JIRA.12413502.1233186687286@arcas>
References: <JIRA.12413502.1233186687286@arcas>
Subject: [jira] [Commented] (SOLR-992) Add Ability To Use JNDI Keys In
 Configuration String Replacement Tags
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604361#comment-13604361 ] 

Erick Erickson commented on SOLR-992:
-------------------------------------

Could someone JNDI-savvy comment here? Or kill this issue..
                
> Add Ability To Use JNDI Keys In Configuration String Replacement Tags
> ---------------------------------------------------------------------
>
>                 Key: SOLR-992
>                 URL: https://issues.apache.org/jira/browse/SOLR-992
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.4
>         Environment: jdk 1.6.x,  Tomcat 5.x, 6.x
>            Reporter: Michael Henson
>            Priority: Minor
>         Attachments: solr-992.zip
>
>
> The configuration syntax allows users to specify tags which will be replaced with values pulled from system properties, or a given default value if the system property can not be found. It could also be useful to allow users to pull replacement values from the JNDI environment configuration.
> Issues:
> 1. Full JNDI tags are specified with a url syntax, which includes a ":" character. The ":" character is currently used to separate the system property name to be used for replacement from the (optional) default value to use.
> 2. JNDI might not be configured for the application's context at all.
> 3. The specified JNDI reference might not be found in the application's context.
> 4. The specified JNDI reference might be malformed.
> The attached patch is a simple first-draft attempt to merge the code used to pull a value for solr.home from JNDI into the variable replacement utility. The syntax I went with for determining that it's a JNDI replacement key is to require a "jndi/" prefix, where anything following that prefix is expected to be a "/"-delimited JNDI path: "jndi/data/home".
> I had to comment out the log references because there is no log object available in the DOMUtil. I also had to replace the reference to "project" with its defined value, since that variable is just a final static String in the SolrResourceLoader class anyway.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org