Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3A9D6F769 for ; Thu, 21 Mar 2013 17:27:53 +0000 (UTC) Received: (qmail 88869 invoked by uid 500); 21 Mar 2013 17:27:52 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 88804 invoked by uid 500); 21 Mar 2013 17:27:52 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 88797 invoked by uid 99); 21 Mar 2013 17:27:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Mar 2013 17:27:51 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of jpountz@gmail.com designates 209.85.214.48 as permitted sender) Received: from [209.85.214.48] (HELO mail-bk0-f48.google.com) (209.85.214.48) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Mar 2013 17:27:45 +0000 Received: by mail-bk0-f48.google.com with SMTP id jf20so1510579bkc.21 for ; Thu, 21 Mar 2013 10:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=qOQcU+3ZMoTtxg8J2SttqRpGBbuomIOQ5lLh4dHOrNo=; b=Aiwmi8PVnVuFwHkq1JT2sN5FYOT3amNtQ0x8MGnLi6TLfJv8RjjbC8+PBwvxLY62zN zXCA2K4TzJv0HVygZnMK+/qTxcxUsoBqh7SDGVb66Bp+9cM/J6/ofAMOrMBDwLqZR372 GrOVDujUEOrCh3A/tQP/QyLEyC11SWbuBsUJHSdUNUpwA2gka8EfqdGNKw/XCyxXIwLR 9y2NuiXiib3mR7HhbDM1TCrAk4oLzbD/0whz5dMPp4/hO792uvW4YRuD5Nzh46NBRUqs 3fxt0nrgH5W+ZcfA2aJ6ovFrgAXTf4QwyTsinzSJ+6B0AJD3d5z7loKt2dV/qzYMfk7d 6P3A== X-Received: by 10.205.118.16 with SMTP id fo16mr13657308bkc.61.1363886845048; Thu, 21 Mar 2013 10:27:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.32.85 with HTTP; Thu, 21 Mar 2013 10:27:04 -0700 (PDT) In-Reply-To: References: <20130321170411.8B71123888EA@eris.apache.org> From: Adrien Grand Date: Thu, 21 Mar 2013 18:27:04 +0100 Message-ID: Subject: Re: svn commit: r1459400 - in /lucene/dev/trunk/lucene: ./ core/src/java/org/apache/lucene/search/ core/src/test/org/apache/lucene/search/ To: dev@lucene.apache.org Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org On Thu, Mar 21, 2013 at 6:18 PM, Robert Muir wrote: > Its not clear to me that this works when IndexSearcher has an executorService. It works because the executed callables use the IndexSearcher.search wich has been modified to deal with CollectionTerminatedException (they just pass a singleton leaf context instead of all the reader's leaves). > can the test use newSearcher or something? Good point, I didn't know about this method. I'll improve the test. -- Adrien --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org