lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "crocket (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-4891) Only a part of CategoryPath is recorded if I add "me" category.
Date Sat, 30 Mar 2013 05:37:16 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616653#comment-13616653
] 

crocket edited comment on LUCENE-4891 at 3/30/13 5:35 AM:
----------------------------------------------------------

I made a test with LUCENE-4882.patch applied locally and a test with OrdinalPolicy.ALL_PARENTS.

Please clone the tests from git://snowberry.me/LuceneTest.git and run "mvn test" in it.

It tests lucene 4.2.

* Test result
1) LUCENE-4882.patch fixes LUCENE-4891 and LUCENE-4882.
2) OrdinalPolicy.ALL_PARENTS fixes LUCENE-4891 but not LUCENE-4882.

Without LUCENE-4882.patch and OrdinalPolicy.ALL_PARENTS, CountingListBuilder.build(IntsRef
ordinals, Iterable<CategoryPath> categories) removes the last element from ordinals
when it meets "me" category.
Thus, CountingListBuilder.build removes "network/hanirc/chan/#anything" but adds its parents
if "network/hanirc/chan/#anything" comes after "me".

I think LUCENE-4882.patch fixes this, but please test git://snowberry.me/LuceneTest.git to
make sure I am not wrong.
                
      was (Author: crocket):
    I made a test with LUCENE-4882.patch applied locally and a test with OrdinalPolicy.ALL_PARENTS.

Please clone the tests from git://snowberry.me/LuceneTest.git and run "mvn test" in it.

It tests lucene 4.2.

** Test result
1) LUCENE-4882.patch fixes LUCENE-4891 and LUCENE-4882.
2) OrdinalPolicy.ALL_PARENTS fixes LUCENE-4891 but not LUCENE-4882.

Without LUCENE-4882.patch and OrdinalPolicy.ALL_PARENTS, CountingListBuilder.build(IntsRef
ordinals, Iterable<CategoryPath> categories) removes the last element from ordinals
when it meets "me" category.
Thus, CountingListBuilder.build removes "network/hanirc/chan/#anything" but adds its parents
if "network/hanirc/chan/#anything" comes after "me".

I think LUCENE-4882.patch fixes this, but please test git://snowberry.me/LuceneTest.git to
make sure I am not wrong.
                  
> Only a part of CategoryPath is recorded if I add "me" category.
> ---------------------------------------------------------------
>
>                 Key: LUCENE-4891
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4891
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/facet
>    Affects Versions: 4.2
>            Reporter: crocket
>
> If I add [type/CHAT, me, network/hanirc/chan/#sdgsdgsd] as "categories" to a document
and add the document to a writer as below, Only "network/hanirc/chan", not "network/hanirc/chan/#sdgsdgsd
"is" recorded into a taxonomy directory. type/CHAT and me are recorded well. I confirmed it
with a test.
> FacetFields ff = new FacetFields(taxoWriter);
> ff.addFields(doc, categories);
> nrtWriter.addDocument(doc);
> If I add [type/CHAT, network/hanirc/chan/#sdgsdgsd] to a document, everything is recorded
fine.
> What's wrong with "me" category?
> You could clone git://snowberry.me/ZeroIrcLog.git and read the code if you want.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message