lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4883) Hide FieldCache behind an UninvertingFilterReader
Date Wed, 27 Mar 2013 10:41:18 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615097#comment-13615097
] 

Robert Muir commented on LUCENE-4883:
-------------------------------------

{quote}
I was wondering about how to do this. We could add an optional Map<String, DocValuesType>
parameter to the UFR constructor - if it's absent, then you can uninvert any field you like,
at the risk of fieldcache-insanity. 
{quote}

Why allow this? I don't think we should do this. it also prevents it from working with anything
that checks fieldinfos.

{quote}
Maybe for the moment we should just get FieldCache moved into UFR and worry about passing
CheckIndex in another issue? Unless you think that we'll end up having to make major changes
if we don't build this in from the beginning. I'm new to a lot of this part of the codebase,
so all advice is very welcome here
{quote}

I think its a pretty big deal that a filterreader pass checkindex, otherwise its corrupt,
and will behave in a corrupt way. there is also nothing to prevent someone from calling IW.addIndexes(IR)
with it and making a truly corrupt index.

I'm willing to budge on this though, if we want to add this filterreader that doesnt pass
checkindex, its ok to me as long as IndexWriter.addIndexes itself internally calls checkIndex
on the incoming filterreader to prevent corruption.
                
> Hide FieldCache behind an UninvertingFilterReader
> -------------------------------------------------
>
>                 Key: LUCENE-4883
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4883
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-4883.patch
>
>
> From a discussion on the mailing list:
> {{
> rmuir:
> I think instead FieldCache should actually be completely package
> private and hidden behind a UninvertingFilterReader and accessible via
> the existing AtomicReader docValues methods.
> }}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message