lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4861) can we use a single PostingsHighlighter for both whole and snippet highlighting?
Date Wed, 20 Mar 2013 16:17:16 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607792#comment-13607792
] 

Robert Muir commented on LUCENE-4861:
-------------------------------------

maybe we can nuke breakiterator from the ctor alltogether and have something like:

{code}
protected BreakIterator getBreakIterator(String field) {
  return BreakIterator.getSentenceInstance(Locale.ROOT);
}
{code}

we'd call this once per-request and remove the clone() we currently have. I think this is
really fast
with most of the JDK breakiterators and if someone has a heavy-duty custom one, they could
just clone()
from their own singleton themselves?
                
> can we use a single PostingsHighlighter for both whole and snippet highlighting?
> --------------------------------------------------------------------------------
>
>                 Key: LUCENE-4861
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4861
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.0, 4.3
>
>
> Right now, because we pass the BreakIterator to the ctor, you have to make two instances
if you sometimes want whole and sometimes want snippets.
> But I think this is a fairly common use case, eg I want entire title field (with matches
highlighted) but I want body field (snippets + highlights).  It would be nice to have this
work with a single instance ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message