lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4860) PostingsHighlighter should pass field name to PassageFormatter.format?
Date Fri, 22 Mar 2013 01:13:15 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609769#comment-13609769
] 

Robert Muir commented on LUCENE-4860:
-------------------------------------

+1
                
> PostingsHighlighter should pass field name to PassageFormatter.format?
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-4860
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4860
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.0, 4.3
>
>         Attachments: LUCENE-4860.patch, LUCENE-4860.patch, LUCENE-4860.patch, LUCENE-4860.patch
>
>
> If the app needs to render different fields (eg multi-valued vs single-valued) differently
it's tricky now.
> You can do Passage[0].getMatchTerms()[0].field(), but then that doesn't work if that
field hit the empty highlight.
> I think we should pass the fieldName to format directly?  And then maybe change getMatchTerms()
to return BytesRef[] instead (the field name is redundant: they are all the same for all passages
passed to format).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message