lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4856) If no Passages are found for a doc, PostingsHighlighter should return first n sentences?
Date Wed, 20 Mar 2013 01:39:15 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607163#comment-13607163
] 

Robert Muir commented on LUCENE-4856:
-------------------------------------

* Maybe the method could be protected so if someone doesnt like whatever we default to, they
can subclass. 
* What will it do if the document doesnt have the field(s)? Return null?
* What score does the passage get?
* If we change the default, some docs need changing: e.g. "If no highlights were found for
a document, its value is <code>null</code>"
* In the main loop, this if check could then go? Or maybe this is the place to do this instead?
{code}
      if (passages.length > 0) {
        // otherwise a null snippet
        highlights.put(doc, formatter.format(passages, content));
      }
{code}

                
> If no Passages are found for a doc, PostingsHighlighter should return first n sentences?
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4856
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4856
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.0, 4.3
>
>         Attachments: LUCENE-4856.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message