lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4848) Fix Directory implementations to use NIO2 APIs
Date Wed, 20 Mar 2013 14:13:16 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607632#comment-13607632
] 

Robert Muir commented on LUCENE-4848:
-------------------------------------

After reviewing the patch, my main concern is the generics on FSIndexInput.

This thing really buys us very little... and adding a generic parameter makes it not worth
the trouble IMO.
So maybe we should just nuke this thing completely and let NIO and SimpleFS just be their
own thing.

(I caused the current situation, but i at least argue its an improvement over NIOFS *extends*
SimpleFS, which is how it was before).
                
> Fix Directory implementations to use NIO2 APIs
> ----------------------------------------------
>
>                 Key: LUCENE-4848
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4848
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Michael Poindexter
>            Assignee: Uwe Schindler
>            Priority: Minor
>         Attachments: jdk7directory.zip, LUCENE-4848-MMapDirectory.patch, LUCENE-4848.patch,
LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch.txt
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on JDK7).  These
may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5 for more details
about this code and the advantages it provides.
> The code is attached as a zip to this issue.  I'll be happy to make any changes requested.
 I've included some minimal smoke tests, but any help in how to use the normal Lucene tests
to perform more thorough testing would be appreciated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message