lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4848) Add Directory implementations using NIO2 APIs
Date Tue, 19 Mar 2013 21:55:17 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606891#comment-13606891
] 

Uwe Schindler commented on LUCENE-4848:
---------------------------------------

There is one other problem, caused by the 2 new abstract methods in the base class: the check
for FS validity is package proetcted and is only used by Lucene tests. If somebody from outside
Lucene code wants to implement a custom FSIndexOutput, it is impossible because the package
proetcted abstract methods. Previously this was not a problem, as the method had a method
body and the compiler was happy.

In my opinion, we should also remove the fileLength(FD) method and simply require the file
size to be passed in ctor.
                
> Add Directory implementations using NIO2 APIs
> ---------------------------------------------
>
>                 Key: LUCENE-4848
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4848
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Michael Poindexter
>            Assignee: Uwe Schindler
>            Priority: Minor
>         Attachments: jdk7directory.zip, LUCENE-4848-MMapDirectory.patch, LUCENE-4848.patch,
LUCENE-4848.patch
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on JDK7).  These
may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5 for more details
about this code and the advantages it provides.
> The code is attached as a zip to this issue.  I'll be happy to make any changes requested.
 I've included some minimal smoke tests, but any help in how to use the normal Lucene tests
to perform more thorough testing would be appreciated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message