lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-4586) Increase default maxBooleanClauses
Date Wed, 27 Mar 2013 09:49:16 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615068#comment-13615068
] 

Robert Muir edited comment on SOLR-4586 at 3/27/13 9:48 AM:
------------------------------------------------------------

{quote}
1) Remove the solr.xml additions.
{quote}

-1. thats where it belongs. its not a per-core thing.

{quote}
2) Log a deprecation warning when maxBooleanClauses is found in solrconfig.xml, but honor
it.
{quote}

-1. As i stated, I want to keep this parameter. its useful.

{quote}
2a) Should we make it possible to go lower than Lucene's default? The current patch won't.
{quote}

Dude. it should be nothing more than doing what the config file says. Seriously, anything
else is a bug.
If i want to have a max of 5, thats my choice.

                
      was (Author: rcmuir):
    {quote}
1) Remove the solr.xml additions.
{quote}

-1. thats where it belongs. its not a per-core thing.

{quote}
2) Log a deprecation warning when maxBooleanClauses is found in solrconfig.xml, but honor
it.
{quote}

=1. As i stated, I want to keep this parameter. its useful.

{quote}
2a) Should we make it possible to go lower than Lucene's default? The current patch won't.
{quote}

Dude. it should be nothing more than doing what the config file says. Seriously, anything
else is a bug.
If i want to have a max of 5, thats my choice.

                  
> Increase default maxBooleanClauses
> ----------------------------------
>
>                 Key: SOLR-4586
>                 URL: https://issues.apache.org/jira/browse/SOLR-4586
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.2
>         Environment: 4.3-SNAPSHOT 1456767M - ncindex - 2013-03-15 13:11:50
>            Reporter: Shawn Heisey
>         Attachments: SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch
>
>
> In the #solr IRC channel, I mentioned the maxBooleanClauses limitation to someone asking
a question about queries.  Mark Miller told me that maxBooleanClauses no longer applies, that
the limitation was removed from Lucene sometime in the 3.x series.  The config still shows
up in the example even in the just-released 4.2.
> Checking through the source code, I found that the config option is parsed and the value
stored in objects, but does not actually seem to be used by anything.  I removed every trace
of it that I could find, and all tests still pass.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message