lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4586) Increase default maxBooleanClauses
Date Sat, 23 Mar 2013 15:21:16 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611735#comment-13611735
] 

Robert Muir commented on SOLR-4586:
-----------------------------------

My recommendation at solr.xml was to fix the bugs and not have complicated logic.

I look at the issue differently: to me the important thing is that its bogus and confusing
today to have this configuration parameter in solrconfig.xml, when it really should be in
solr.xml, since it cannot be applied per-core. This is just a straight up bug! And I dont
think the limit should be adjusted until this bug is fixed: otherwise it will just create
more bugs (or at least confusing logic, like the last one or highest one or whatever is picked).

So it should be in solr.xml, and no one gets confused, and there is no need for confusing
logic (picking the last one, or the highest one, or whatever). If someone has it specified
in solrconfig.xml, some action should be taken: a nice person might argue for just a warning
or similar in 4.x and just a straight up error (refuse to start) in 5.x.
                
> Increase default maxBooleanClauses
> ----------------------------------
>
>                 Key: SOLR-4586
>                 URL: https://issues.apache.org/jira/browse/SOLR-4586
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.2
>         Environment: 4.3-SNAPSHOT 1456767M - ncindex - 2013-03-15 13:11:50
>            Reporter: Shawn Heisey
>         Attachments: SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch
>
>
> In the #solr IRC channel, I mentioned the maxBooleanClauses limitation to someone asking
a question about queries.  Mark Miller told me that maxBooleanClauses no longer applies, that
the limitation was removed from Lucene sometime in the 3.x series.  The config still shows
up in the example even in the just-released 4.2.
> Checking through the source code, I found that the config option is parsed and the value
stored in objects, but does not actually seem to be used by anything.  I removed every trace
of it that I could find, and all tests still pass.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message