lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4575) SOLR-4196 took away the ability to use solr.core.name (and others) in solrconfig & etc.
Date Thu, 14 Mar 2013 11:48:12 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602205#comment-13602205
] 

Erick Erickson commented on SOLR-4575:
--------------------------------------

Mark:

Actually, I had it completely backwards. Restoring this behavior doesn't require that you
define, for instance, "solr.core.name" in core.properties, you should still just use "name".
These are the "implicit properties" that you can refer to in, for instance, solrconfig.xml.

The only real back-compat cost at this point is carrying around two entries for each of the
listed properties in coredescriptor, e.g.

name => collection1
and
solr.core.name => collection1

In fact, in this example in solrconfig.xml, you could ask for
<infoStream file="INFOSTREAM-${solr.core.name}.txt">false</infoStream>
or
<infoStream file="INFOSTREAM-${name}.txt">false</infoStream> 
and get the same results.

So with that cost I think we should put this behavior back rather than pull the rug out from
under existing behavior. If we want to yank it for 5.0 all we have to do is remove CoreContainer.initImplicitProperties.


                
> SOLR-4196 took away the ability to use solr.core.name (and others) in solrconfig &
etc.
> ---------------------------------------------------------------------------------------
>
>                 Key: SOLR-4575
>                 URL: https://issues.apache.org/jira/browse/SOLR-4575
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>         Attachments: SOLR-4575.patch, SOLR-4575.patch, SOLR-4575.patch
>
>
> solr.core.name
> solr.core.instanceDir
> solr.core.dataDir
> solr.core.configName
> solr.core.schemaName
>  
> all are introduced (without necessarily reading them from the environment) so they can
be referenced in various config files (e.g. solrconfig.xml) or passed through as system vars.
> Shawn:
> Thans for pointing at that specific revision, made it much easier for me to pinpoint.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message