lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Commit Tag Bot (JIRA)" <>
Subject [jira] [Commented] (SOLR-4566) clusterstate#getSlices and getSlicesMap should always return all slices.
Date Wed, 13 Mar 2013 14:20:14 GMT


Commit Tag Bot commented on SOLR-4566:

[branch_4x commit] Mark Robert Miller

SOLR-4566: revert

> clusterstate#getSlices and getSlicesMap should always return all slices.
> ------------------------------------------------------------------------
>                 Key: SOLR-4566
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.3, 5.0
> I'm not sure I really like this getSlices vs getAllSclies - it's kind of easy to get
in trouble right now I think. Some spots that we clearly want to call getAllSlices got left
with getSlices. It's almost surprising that getSlices only returns active replicas - it should
probably at least be called getSlicesWithActive or something more explicit. But for the first
step, we should just fix the various mis calls.
> There are a couple problems around the mis calls, the most severe probably being that
you can lose shards that are not active from the clusterstate.json given the right races.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message