lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Commit Tag Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4566) clusterstate#getSlices and getSlicesMap should always return all slices.
Date Wed, 13 Mar 2013 14:20:14 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601174#comment-13601174
] 

Commit Tag Bot commented on SOLR-4566:
--------------------------------------

[branch_4x commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revision&revision=1455945

SOLR-4566: revert

                
> clusterstate#getSlices and getSlicesMap should always return all slices.
> ------------------------------------------------------------------------
>
>                 Key: SOLR-4566
>                 URL: https://issues.apache.org/jira/browse/SOLR-4566
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.3, 5.0
>
>
> I'm not sure I really like this getSlices vs getAllSclies - it's kind of easy to get
in trouble right now I think. Some spots that we clearly want to call getAllSlices got left
with getSlices. It's almost surprising that getSlices only returns active replicas - it should
probably at least be called getSlicesWithActive or something more explicit. But for the first
step, we should just fix the various mis calls.
> There are a couple problems around the mis calls, the most severe probably being that
you can lose shards that are not active from the clusterstate.json given the right races.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message