lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Commit Tag Bot (JIRA)" <>
Subject [jira] [Commented] (SOLR-4557) Fix broken CoreContainerTest.testReload
Date Wed, 13 Mar 2013 13:10:19 GMT


Commit Tag Bot commented on SOLR-4557:

[trunk commit] Erick Erickson

Fix for SOLR-4557, fixes for reload testing. Also made a series of changes to make reloading
cores more robust

> Fix broken CoreContainerTest.testReload
> ---------------------------------------
>                 Key: SOLR-4557
>                 URL:
>             Project: Solr
>          Issue Type: Test
>    Affects Versions: 4.2, 5.0
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>             Fix For: 4.3, 5.0
>         Attachments: SOLR-4557.patch, SOLR-4557.patch, SOLR-4557_posthshutdown_stack.txt
> I was chasing down a test failure, and it turns out that CoreContainerTest.testReload
has only succeeded by chance. The test fires up 4 threads that go out and reload the same
core all at once. This caused me to look at properly synchronizing reloading cores pursuant
to SOLR-4196, on the theory that we should serialize loading, unloading and reloading cores;
we shouldn't be doing _any_ of those operations from different threads on the same core at
the same time. It turns out that if you fire up multiple reloads at once without serializing
them, an error is thrown instead of proper reloading occurring, and that's the only reason
the test doesn't hang. The stack trace of the exception is below for reference, but it doesn't
with the code I'll attach to this patch:
> [junit4:junit4]   2> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(
> [junit4:junit4]   2> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.exclusiveUnregisterMBean(
> [junit4:junit4]   2> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.unregisterMBean(
> [junit4:junit4]   2> 	at com.sun.jmx.mbeanserver.JmxMBeanServer.unregisterMBean(
> [junit4:junit4]   2> 	at org.apache.solr.core.JmxMonitoredMap.put(
> [junit4:junit4]   2> 	at org.apache.solr.core.JmxMonitoredMap.put(
> [junit4:junit4]   2> 	at org.apache.solr.core.RequestHandlers.register(
> [junit4:junit4]   2> 	at org.apache.solr.core.RequestHandlers.initHandlersFromConfig(
> [junit4:junit4]   2> 	at org.apache.solr.core.SolrCore.<init>(
> [junit4:junit4]   2> 	at org.apache.solr.core.SolrCore.reload(
> [junit4:junit4]   2> 	at org.apache.solr.core.CoreContainer.reload(
> [junit4:junit4]   2> 	at org.apache.solr.core.TestCoreContainer$

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message