lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4544) Allow HttpShardHandler to be reused better by subclasses of HttpShardHandlerFactory
Date Thu, 14 Mar 2013 14:34:12 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602314#comment-13602314
] 

Robert Muir commented on SOLR-4544:
-----------------------------------

Looks good. One thing that sticks out at me while reviewing (not anything introduced by your
patch), is that this factory 
uses a Random initialized from the default ctor (e.g. current time or whatever) to shuffle
the shards.

It seems like this would make it hard for unit tests to have deterministic behavior. I think
we should add a new parameter
that allows you to set the random seed (if not specified, System.currentTimeMillis() or whatever).
Solr test framework could
use this parameter so that you have the same behavior when you run the test with the same
-Dtests.seed.

                
> Allow HttpShardHandler to be reused better by subclasses of HttpShardHandlerFactory
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-4544
>                 URL: https://issues.apache.org/jira/browse/SOLR-4544
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan Ernst
>         Attachments: SOLR-4544.patch, SOLR-4544.patch
>
>
> I would like to have a custom ShardHandlerFactory, which has my own special load balancing
logic (among other things).  The HttpShardHandler is what currently handles the parallelization
of shard requests.  I would like to reuse it, but it expects package private variables in
HttpShardHandlerFactory which it can reach back into for making load balancer requests and
a completion service.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message