lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-4514) Need tests for OpenExchangeRatesOrgProvider
Date Fri, 01 Mar 2013 06:09:12 GMT

     [ https://issues.apache.org/jira/browse/SOLR-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man updated SOLR-4514:
---------------------------

    Attachment: SOLR-4514.patch

Oy, that last patch sucked so hard i don't even have the energy to list all the things wrong
with it.

                
> Need tests for OpenExchangeRatesOrgProvider
> -------------------------------------------
>
>                 Key: SOLR-4514
>                 URL: https://issues.apache.org/jira/browse/SOLR-4514
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-4514.patch, SOLR-4514.patch
>
>
> the schema.xml used by CurrencyFieldTest declares a fieldType named "openexchangeratesorg_currency"
using OpenExchangeRatesOrgProvider pointed at a local copy of open-exchange-rates.json, but
field type is completley unused, so nothing about this provider's behavior is ever really
tested.
> We should change the test such that all of the functionality tested against the "amount"
field is also tested against some new field using this OER provider based fieldType, where
the copied data (and static exchange rates) are identical.
> (esasiest way would probably be to introduce a test variable for the field name and let
a new subclass override it)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message