lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4642) Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource
Date Wed, 13 Mar 2013 04:10:15 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600793#comment-13600793
] 

Steve Rowe commented on LUCENE-4642:
------------------------------------

Somewhere else?  You mean, everywhere it's used?

bq. I really don't like separate methods. This will cause bugs and confusion.

Can you expand on this thought?  Is this the constructor explosion argument?  If not, what
sort of bugs and confusion do you see happening?

                
> Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory,
and remove Tokenizer's and subclasses' ctors taking AttributeSource
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4642
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4642
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.1
>            Reporter: Renaud Delbru
>            Assignee: Steve Rowe
>              Labels: analysis, attribute, tokenizer
>             Fix For: 4.3
>
>         Attachments: LUCENE-4642.patch, LUCENE-4642.patch, LUCENE-4642.patch, LUCENE-4642.patch,
TrieTokenizerFactory.java.patch
>
>
> All tokenizer implementations have a constructor that takes a given AttributeSource as
parameter (LUCENE-1826).  These should be removed.
> TokenizerFactory does not provide an API to create tokenizers with a given AttributeFactory,
but quite a few tokenizers have constructors that take an AttributeFactory.  TokenizerFactory
should add a create(AttributeFactory) method, as should subclasses for tokenizers with AttributeFactory
accepting ctors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message