lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Commit Tag Bot (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4469) many Test2B* tests appear to be useless
Date Fri, 22 Mar 2013 16:29:16 GMT


Commit Tag Bot commented on LUCENE-4469:

[branch_4x commit] Robert Muir

LUCENE-4469: fix these tests to actually fail if checkindex fails

> many Test2B* tests appear to be useless
> ---------------------------------------
>                 Key: LUCENE-4469
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 4.1, 5.0
> for some reason (I guess debugging) these explicitly disable checkindex on MDW and call
checkindex themselves.
> but they dont check its return value!
> So these tests could currently all be failing and we wouldnt know (since If i remember
right, checkindex catches throwable and records it inside its status)
> These tests should be changed to just let MDW run the checkindex, or use _TestUtil.checkIndex.
> We should also search the codebase for any other tests doing this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message