lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Commit Tag Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4443) BlockPostingsFormat writes unnecessary skipdata
Date Fri, 22 Mar 2013 16:31:21 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610732#comment-13610732
] 

Commit Tag Bot commented on LUCENE-4443:
----------------------------------------

[branch_4x commit] Robert Muir
http://svn.apache.org/viewvc?view=revision&revision=1391479

LUCENE-4443: don't write unnecessary skipdata in BlockSkipWriter

                
> BlockPostingsFormat writes unnecessary skipdata
> -----------------------------------------------
>
>                 Key: LUCENE-4443
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4443
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4443.patch
>
>
> Seems to me lastStartOffset is unnecessary, when we skip to a document, it implicitly
is 0: see BlockPostingsWriter.startDoc.
> (Unless I'm missing something, all tests pass with "Block" if i remove it)
> Separately we should really think about lastPayloadByteUpto, is this worth it? instead
when we actually skip, we could sum the payloadLengthBuffer from 0..curPosBufferUpto as we
are going to decode that block anyway?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message